Feat/exchange object meta signatures #2936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes too much of network/disk to handle tombstones expiration and removal, so it is better to store it when tombstone is being indexed in metabase. Additional little-endian expiration suffix was added to graveyard values. Metabase version was increased as it is a non-compatible change. Relates #2929. Signed-off-by: Pavel Karpy <[email protected]>
They do not differ from the other objects (e.g. locks do). Initial logic has changed much, graveyard now allows to handle expired tombstones marks (do not confuse it with the lists of regular indexes) independently, while disk can be cleared with the other types of object. Also, add tests for it. Signed-off-by: Pavel Karpy <[email protected]>
Graveyard now has tombstone expiration marks in epochs, there is no need to use any network requests, just drop records if an epoch is big enough. Closes #2929. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
It may or may not index tombstone's expiration in graveyard. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/exchange-object-meta-signatures
branch
from
eb9b0d1
to
28fd1e7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
+ Coverage 23.90% 24.00% +0.09%
==========================================
Files 776 773 -3
Lines 45708 45580 -128
==========================================
+ Hits 10928 10942 +14
+ Misses 33920 33780 -140
+ Partials 860 858 -2 ☔ View full report in Codecov by Sentry. |
|
wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.